Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubGHz: Add back region lock and manual bypass option #47

Merged
merged 10 commits into from
Mar 20, 2024
Merged

SubGHz: Add back region lock and manual bypass option #47

merged 10 commits into from
Mar 20, 2024

Conversation

Sil333033
Copy link
Member

What's new

  • Functional region hal back to the Flipper. Now we can use the regions to determine if you are allowed to transmit on the chosen frequency.
  • Brought back an option to bypass it inside the Momentum app.
  • Reworked 'furi_hal_subghz_is_tx_allowed()' to actually use the region check.
  • Flipper gets forced rebooted after changing the SubGHz region bypass or frequency extenstion inside the Momentum app, because those settings are loaded on startup. We could change it with an extra 'furi_hal_subghz_set_extended_frequency(bool state)' function, but these settings aren't changed often.

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL
Copy link
Member

We could change it with an extra 'furi_hal_subghz_set_extended_frequency(bool state)' function, but these settings aren't changed often.

I wanted to do this, but actually it would require exposing this functionality to API symbols... not worth it :D

@Willy-JL Willy-JL merged commit 0111d85 into dev Mar 20, 2024
3 checks passed
@Willy-JL Willy-JL deleted the bringsubghzbypassback branch March 20, 2024 01:01
@Willy-JL Willy-JL added the enhancement New enhancement or request label Mar 20, 2024
@Willy-JL Willy-JL changed the title SubGHz: Manual region bypass SubGHz: Add back region lock and manual bypass option Mar 20, 2024
@Willy-JL Willy-JL self-assigned this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@Willy-JL Willy-JL

@Sil333033 Sil333033

Labels
enhancement New enhancement or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sil333033 @Willy-JL